Fix #250

src/server/autocomplete.d

@@ -819,8 +819,11 @@ void setCompletions(T)(ref AutocompleteResponse response,
 	Scope* completionScope, T tokens, size_t cursorPosition,
 	CompletionType completionType, bool isBracket = false, string partial = null)
 {
-	static void addSymToResponse(DSymbol* s, ref AutocompleteResponse r, string p)
+	static void addSymToResponse(DSymbol* s, ref AutocompleteResponse r, string p,
+		size_t[] circularGuard = [])
 	{
+		if (circularGuard.canFind(cast(size_t) s))
+			return;
 		foreach (sym; s.opSlice())
 		{
 			if (sym.name !is null && sym.name.length > 0 && sym.kind != CompletionKind.importSymbol
@@ -831,7 +834,7 @@ void setCompletions(T)(ref AutocompleteResponse response,
 				r.completions ~= sym.name.dup;
 			}
 			if (sym.kind == CompletionKind.importSymbol && !sym.skipOver && sym.type !is null)
-				addSymToResponse(sym.type, r, p);
+				addSymToResponse(sym.type, r, p, circularGuard ~ (cast(size_t) s));
 		}
 	}
 

tests/imports/circular/a.d

@@ -0,0 +1,5 @@
+module circular.a;
+public import circular.b;
+
+int alpha;
+

tests/imports/circular/b.d

@@ -0,0 +1,4 @@
+module circular.b;
+public import circular.a;
+
+int bravo;

tests/imports/circular/x.d

@@ -0,0 +1,4 @@
+module circular.x;
+public import circular.y;
+
+int x_ray;

tests/imports/circular/y.d

@@ -0,0 +1,4 @@
+module circular.y;
+public import circular.z;
+
+int yankee;

tests/imports/circular/z.d

@@ -0,0 +1,4 @@
+module circular.z;
+public import circular.x;
+
+int zulu;

tests/tc018/expected1.txt

@@ -0,0 +1,3 @@
+identifiers
+alpha	v
+bravo	v

tests/tc018/expected2.txt

@@ -0,0 +1,4 @@
+identifiers
+x_ray	v
+yankee	v
+zulu	v

tests/tc018/file.d

@@ -0,0 +1,12 @@
+import circular.a;
+import circular.x;
+unittest
+{
+	circular.a.
+}
+
+unittest
+{
+	circular.x.
+}
+

tests/tc018/run.sh

@@ -0,0 +1,8 @@
+set -e
+set -u
+
+../../bin/dcd-client file.d -c61 > actual1.txt
+diff actual1.txt expected1.txt
+
+../../bin/dcd-client file.d -c88 > actual2.txt
+diff actual2.txt expected2.txt