forks
/
D-Scanner
mirror of https://github.com/dlang-community/D-Scanner.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #761 from wilzbach/fix-760 

Fix #760 - ignore deprecated symbols in the undocumented check
This commit is contained in:
Sebastian Wilzbach 2019-05-15 00:57:15 +02:00 committed by GitHub
parent e8180d64a6 e2b5f852e6
commit e5a73fa0ef
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 15 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
containers

@ -1 +1 @@
Subproject commit 257c0418f34709dd667f95b5dffabedc2b3099e4 Subproject commit a978c3cda3f6ec3ba7449ec5c08dd5cd4dd79c6e

15
src/dscanner/analysis/undocumented.d
View File

@ -150,6 +150,13 @@ private:
override void visit(const T declaration) override void visit(const T declaration)
{ {
import std.traits : hasMember; import std.traits : hasMember;
static if (hasMember!(T, "storageClasses"))
{
// stop at declarations with a deprecated in their storage classes
foreach (sc; declaration.storageClasses)
if (sc.deprecated_ !is null)
return;
}
if (currentIsInteresting()) if (currentIsInteresting())
{ {
@ -248,7 +255,7 @@ private:
bool currentIsInteresting() bool currentIsInteresting()
{ {
return stack[$ - 1].protection == tok!"public" return stack[$ - 1].protection == tok!"public"
&& !stack[$ - 1].isOverride && !stack[$ - 1].isDisabled && !stack[$ - 1].isDeprecated; && !getOverride() && !getDisabled() && !getDeprecated();
} }
void set(IdType p) void set(IdType p)
@ -332,6 +339,12 @@ unittest
union U{} union U{}
}, sac); }, sac);
// https://github.com/dlang-community/D-Scanner/issues/760
assertAnalyzerWarnings(q{
deprecated auto func(){}
deprecated auto func()(){}
}, sac);
stderr.writeln("Unittest for UndocumentedDeclarationCheck passed."); stderr.writeln("Unittest for UndocumentedDeclarationCheck passed.");
} }