forks
/
D-Scanner
mirror of https://github.com/dlang-community/D-Scanner.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix range error in mismatched argument checker, disable logging from dsymbol

This commit is contained in:
Hackerpilot 2015-09-18 04:06:18 -07:00
parent 6dc1cb9191
commit c09abbdab6
2 changed files with 55 additions and 52 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
makefile
View File

@ -19,7 +19,7 @@ INCLUDE_PATHS = \
-Idsymbol/src -Icontainers/src
VERSIONS =
DEBUG_VERSIONS = -version=std_parser_verbose
DMD_FLAGS = -w -O -inline -J. -od${OBJ_DIR}
DMD_FLAGS = -w -O -inline -J. -od${OBJ_DIR} -version=StdLoggerDisableWarning
DMD_TEST_FLAGS = -w -g -unittest -J.
all: dmdbuild

11
src/analysis/mismatched_args.d
View File

@ -5,6 +5,7 @@ import dsymbol.scope_;
import dsymbol.symbol;
import std.d.ast;
import std.d.lexer : tok;
import dsymbol.builtin.names;
/// Checks for mismatched argument and parameter names
final class MismatchedArgumentCheck : BaseAnalyzer
@ -30,7 +31,8 @@ final class MismatchedArgumentCheck : BaseAnalyzer
auto identVisitor = scoped!IdentVisitor;
identVisitor.visit(fce.unaryExpression);
const(DSymbol)* sym = resolveSymbol(sc, identVisitor.names);
const(DSymbol)* sym = resolveSymbol(sc,
identVisitor.names.length > 0 ? identVisitor.names : [CONSTRUCTOR_SYMBOL_NAME]);
const istring[] params = sym is null ? [] : sym.opSlice().map!(a => cast() a.name).array();
const ArgMismatch[] mismatches = compareArgsToParams(params, args);
foreach (size_t i, ref const mm; mismatches)
@ -124,7 +126,8 @@ const(DSymbol)* resolveSymbol(const Scope* sc, const istring[] symbolChain)
const(DSymbol)* sym = s[0];
foreach (i; 1 .. symbolChain.length)
{
if (sym.kind == CompletionKind.variableName || sym.kind == CompletionKind.memberVariableName
if (sym.kind == CompletionKind.variableName
|| sym.kind == CompletionKind.memberVariableName
|| sym.kind == CompletionKind.functionName)
sym = sym.type;
if (sym is null)
@ -164,8 +167,8 @@ string createWarningFromMismatch(const ArgMismatch mismatch) pure
{
import std.format : format;
return "Argument %d is named '%s', but this is the name of parameter %d"
.format(mismatch.argIndex + 1, mismatch.name, mismatch.paramIndex + 1);
return "Argument %d is named '%s', but this is the name of parameter %d".format(
mismatch.argIndex + 1, mismatch.name, mismatch.paramIndex + 1);
}
unittest