forks
/
D-Scanner
mirror of https://github.com/dlang-community/D-Scanner.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

add unittest for FunctionAttributeCheck

This commit is contained in:
brianush1 2022-12-28 13:13:08 -05:00 committed by Jan Jurzitza
parent 14ba4af4bd
commit ba4617efac
1 changed files with 37 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

37
src/dscanner/analysis/function_attributes.d
View File

@ -6,6 +6,7 @@
module dscanner.analysis.function_attributes;
import dscanner.analysis.base;
import dscanner.analysis.helpers;
import dparse.ast;
import dparse.lexer;
import std.stdio;
@ -147,3 +148,39 @@ private:
enum string ABSTRACT_MESSAGE = "'abstract' attribute is redundant in interface declarations";
enum string KEY = "dscanner.confusing.function_attributes";
}
unittest
{
import dscanner.analysis.config : StaticAnalysisConfig, Check, disabledConfig;
StaticAnalysisConfig sac = disabledConfig();
sac.function_attribute_check = Check.enabled;
assertAnalyzerWarnings(q{
int foo() @property { return 0; }
const int confusingConst() { return 0; } // [warn]: 'const' is not an attribute of the return type. Place it after the parameter list to clarify.
class ClassName {
int bar() @property { return 0; } // [warn]: Zero-parameter '@property' function should be marked 'const', 'inout', or 'immutable'.
int barConst() const @property { return 0; }
}
struct StructName {
int bar() @property { return 0; } // [warn]: Zero-parameter '@property' function should be marked 'const', 'inout', or 'immutable'.
int barConst() const @property { return 0; }
}
union UnionName {
int bar() @property { return 0; } // [warn]: Zero-parameter '@property' function should be marked 'const', 'inout', or 'immutable'.
int barConst() const @property { return 0; }
}
interface InterfaceName {
int bar() @property; // [warn]: Zero-parameter '@property' function should be marked 'const', 'inout', or 'immutable'.
int barConst() const @property;
abstract int method(); // [warn]: 'abstract' attribute is redundant in interface declarations
}
}c, sac);
stderr.writeln("Unittest for FunctionAttributeCheck passed.");
}