forks
/
D-Scanner
mirror of https://github.com/dlang-community/D-Scanner.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix false positive for strings with newlines

This commit is contained in:
Hackerpilot 2015-10-30 14:41:38 -07:00
parent ceff31d216
commit b3e22eb10e
1 changed files with 16 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
src/analysis/line_length.d
View File

@ -26,7 +26,7 @@ class LineLengthCheck : BaseAnalyzer
ulong lastErrorLine = ulong.max; ulong lastErrorLine = ulong.max;
foreach (token; tokens) foreach (token; tokens)
{ {
if (token.column + token.text.length > MAX_LINE_LENGTH && token.line != lastErrorLine) if (tokenEndColumn(token) > MAX_LINE_LENGTH && token.line != lastErrorLine)
{ {
addErrorMessage(token.line, token.column, KEY, MESSAGE); addErrorMessage(token.line, token.column, KEY, MESSAGE);
lastErrorLine = token.line; lastErrorLine = token.line;
@ -38,6 +38,21 @@ class LineLengthCheck : BaseAnalyzer
private: private:
static ulong tokenEndColumn(ref const Token tok)
{
import std.uni : lineSep, paraSep;
ulong endColumn = tok.column;
foreach (dchar c; tok.text)
{
if (c == lineSep || c == '\n' || c == '\v' || c == '\r' || c == paraSep)
endColumn = 0;
else
endColumn++;
}
return endColumn;
}
import std.conv : to; import std.conv : to;
enum string KEY = "dscanner.style.long_line"; enum string KEY = "dscanner.style.long_line";