forks
/
D-Scanner
mirror of https://github.com/dlang-community/D-Scanner.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix #665 - The check for auto function without return doesn't handle "implicit auto functions"

This commit is contained in:
Basile Burg 2018-06-20 12:32:38 +02:00
parent 76d8a30d23
commit af252569f7
1 changed files with 11 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/dscanner/analysis/auto_function.d
View File

@ -49,7 +49,7 @@ public:
_returns[$-1] = false; _returns[$-1] = false;
const bool autoFun = decl.storageClasses const bool autoFun = decl.storageClasses
.any!(a => a.token.type == tok!"auto"); .any!(a => a.token.type == tok!"auto" || a.atAttribute !is null);
decl.accept(this); decl.accept(this);
@ -216,6 +216,16 @@ unittest
AutoFunctionChecker.MESSAGE, AutoFunctionChecker.MESSAGE,
), sac); ), sac);
assertAnalyzerWarnings(q{
@property doStuff(){} // [warn]: %s
@safe doStuff(){} // [warn]: %s
@disable doStuff();
@safe void doStuff();
}c.format(
AutoFunctionChecker.MESSAGE,
AutoFunctionChecker.MESSAGE,
), sac);
assertAnalyzerWarnings(q{ assertAnalyzerWarnings(q{
enum _genSave = "return true;"; enum _genSave = "return true;";
auto doStuff(){ mixin(_genSave);} auto doStuff(){ mixin(_genSave);}