forks
/
D-Scanner
mirror of https://github.com/dlang-community/D-Scanner.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix #658 - warning about non-const should not be emitted if the methods are `@disable`

This commit is contained in:
Basile Burg 2018-06-12 11:18:55 +02:00
parent 4b394c2a7d
commit aaf06fd500
1 changed files with 28 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

34
src/dscanner/analysis/objectconst.d
View File

@ -51,13 +51,25 @@ final class ObjectConstCheck : BaseAnalyzer
constBlock = true;
}
if (inAggregate && d.functionDeclaration !is null && !constColon && !constBlock
&& isInteresting(d.functionDeclaration.name.text)
&& !hasConst(d.functionDeclaration.memberFunctionAttributes))
bool containsDisable(A)(const A[] attribs)
{
addErrorMessage(d.functionDeclaration.name.line,
d.functionDeclaration.name.column, "dscanner.suspicious.object_const",
"Methods 'opCmp', 'toHash', 'opEquals', 'opCast', and/or 'toString' are non-const.");
import std.algorithm.searching : canFind;
return attribs.canFind!(a => a.atAttribute !is null &&
a.atAttribute.identifier.text == "disable");
}
if (const FunctionDeclaration fd = d.functionDeclaration)
{
const isDeclationDisabled = containsDisable(d.attributes) ||
containsDisable(fd.memberFunctionAttributes);
if (inAggregate && !constColon && !constBlock && !isDeclationDisabled
&& isInteresting(fd.name.text) && !hasConst(fd.memberFunctionAttributes))
{
addErrorMessage(d.functionDeclaration.name.line,
d.functionDeclaration.name.column, "dscanner.suspicious.object_const",
"Methods 'opCmp', 'toHash', 'opEquals', 'opCast', and/or 'toString' are non-const.");
}
}
d.accept(this);
@ -130,6 +142,16 @@ unittest
const{ override string toString() { return "foo"; }} // ok
}
class Rat
{
bool opEquals(Object a, Object b) @disable; // ok
}
class Ant
{
@disable bool opEquals(Object a, Object b); // ok
}
// Will warn, because none are const
class Dog
{