forks
/
D-Scanner
mirror of https://github.com/dlang-community/D-Scanner.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix - adaptation to correct DIP 1009 impl. was incomplete (#728) 

fix - adaptation to correct DIP 1009 impl. was incomplete
merged-on-behalf-of: BBasile <BBasile@users.noreply.github.com>
This commit is contained in:
BBasile 2018-11-29 09:51:23 +01:00 committed by The Dlang Bot
parent 83c89ddc22
commit 9ef6d0aec1
3 changed files with 11 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
.travis.sh
View File

@ -13,5 +13,5 @@ else
make lint make lint
git clone https://www.github.com/dlang/phobos.git --depth=1 git clone https://www.github.com/dlang/phobos.git --depth=1
# just check that it doesn't crash # just check that it doesn't crash
cd phobos && ../bin/dscanner -S --config=.dscanner.ini || true cd phobos/std && ../../bin/dscanner -S --config=../.dscanner.ini || true
fi fi

2
src/dscanner/analysis/properly_documented_public_functions.d
View File

@ -180,7 +180,7 @@ final class ProperlyDocumentedPublicFunctions : BaseAnalyzer
import std.array : Appender; import std.array : Appender;
// ignore header declaration for now // ignore header declaration for now
if (decl.functionBody is null) if (!decl.functionBody || !decl.functionBody.specifiedFunctionBody)
return; return;
if (nestedFuncs == 1) if (nestedFuncs == 1)

10
src/dscanner/analysis/unused.d
View File

@ -49,7 +49,7 @@ final class UnusedVariableCheck : BaseAnalyzer
override void visit(const FunctionDeclaration functionDec) override void visit(const FunctionDeclaration functionDec)
{ {
pushScope(); pushScope();
if (functionDec.functionBody !is null) if (functionDec.functionBody && functionDec.functionBody.specifiedFunctionBody)
{ {
immutable bool ias = inAggregateScope; immutable bool ias = inAggregateScope;
inAggregateScope = false; inAggregateScope = false;
@ -473,6 +473,14 @@ private:
*(cast(FieldType*)(retVal.ptr + byteIndex)) = item; *(cast(FieldType*)(retVal.ptr + byteIndex)) = item;
} }
// bug encountered after correct DIP 1009 impl in dparse
version (StdDdoc)
{
bool isAbsolute(R)(R path) pure nothrow @safe
if (isRandomAccessRange!R && isSomeChar!(ElementType!R) ||
is(StringTypeOf!R));
}
unittest unittest
{ {
int a; // [warn]: Variable a is never used. int a; // [warn]: Variable a is never used.