forks
/
D-Scanner
mirror of https://github.com/dlang-community/D-Scanner.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Implement #126

This commit is contained in:
Hackerpilot 2015-01-03 20:44:31 -08:00
parent fa5f08d741
commit 93b3873ae0
1 changed files with 25 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
src/analysis/function_attributes.d
View File

@ -48,13 +48,37 @@ class FunctionAttributeCheck : BaseAnalyzer
override void visit(const AttributeDeclaration dec) override void visit(const AttributeDeclaration dec)
{ {
if (inInterface > 0 && dec.attribute.attribute == tok!"abstract") if (inInterface && dec.attribute.attribute == tok!"abstract")
{ {
addErrorMessage(dec.attribute.attribute.line, addErrorMessage(dec.attribute.attribute.line,
dec.attribute.attribute.column, KEY, ABSTRACT_MESSAGE); dec.attribute.attribute.column, KEY, ABSTRACT_MESSAGE);
} }
} }
override void visit(const FunctionDeclaration dec)
{
if (dec.parameters.parameters.length == 0)
{
bool foundConst = false;
bool foundProperty = false;
foreach (attribute; dec.attributes)
foundConst = foundConst || attribute.attribute.type == tok!"const";
foreach (attribute; dec.memberFunctionAttributes)
{
foundProperty = foundProperty || (attribute.atAttribute !is null
&& attribute.atAttribute.identifier.text == "property");
foundConst = foundConst || (attribute.tokenType == tok!"const");
}
if (foundProperty && !foundConst)
{
addErrorMessage(dec.name.line, dec.name.column, KEY,
"Zero-parameter '@property' function should be"
~ " marked 'const'. ");
}
}
dec.accept(this);
}
override void visit(const Declaration dec) override void visit(const Declaration dec)
{ {
if (dec.attributes.length == 0) if (dec.attributes.length == 0)