forks
/
D-Scanner
mirror of https://github.com/dlang-community/D-Scanner.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #790 from MoonlightSentinel/unused-enum 

Fix #788: Enum value used inside __traits(...) flagged as unused
This commit is contained in:
Sebastian Wilzbach 2020-02-10 19:31:28 +01:00 committed by GitHub
parent 241a38be1a 4f417b64a1
commit 9364d6f15f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 35 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

42
src/dscanner/analysis/unused_variable.d
View File

@ -19,6 +19,12 @@ final class UnusedVariableCheck : UnusedIdentifierCheck
mixin AnalyzerInfo!"unused_variable_check";
/**
Ignore declarations which are allowed to be unused, e.g. inside of a
speculative compilation: __traits(compiles, { S s = 0; })
**/
uint ignoreDeclarations = 0;
/**
* Params:
* fileName = the name of the file being analyzed
@ -42,17 +48,30 @@ final class UnusedVariableCheck : UnusedIdentifierCheck
autoDeclaration.accept(this);
}
override void visit(const TraitsExpression traitsExp)
{
// issue #788: Enum values might be used inside of `__traits` expressions, e.g.:
// enum name = "abc";
// __traits(hasMember, S, name);
ignoreDeclarations++;
traitsExp.templateArgumentList.accept(this);
ignoreDeclarations--;
}
override protected void popScope()
{
foreach (uu; tree[$ - 1])
if (!ignoreDeclarations)
{
if (!uu.isRef && tree.length > 1)
foreach (uu; tree[$ - 1])
{
if (uu.uncertain)
continue;
immutable string errorMessage = "Variable " ~ uu.name ~ " is never used.";
addErrorMessage(uu.line, uu.column,
"dscanner.suspicious.unused_variable", errorMessage);
if (!uu.isRef && tree.length > 1)
{
if (uu.uncertain)
continue;
immutable string errorMessage = "Variable " ~ uu.name ~ " is never used.";
addErrorMessage(uu.line, uu.column,
"dscanner.suspicious.unused_variable", errorMessage);
}
}
}
tree = tree[0 .. $ - 1];
@ -124,6 +143,15 @@ final class UnusedVariableCheck : UnusedIdentifierCheck
testValue.writeln;
}
// Issue 788
void traits()
{
enum fieldName = "abc";
__traits(hasMember, S, fieldName);
__traits(compiles, { int i = 2; });
}
}c, sac);
stderr.writeln("Unittest for UnusedVariableCheck passed.");
}