forks
/
D-Scanner
mirror of https://github.com/dlang-community/D-Scanner.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #396 from BBasile/issue-364 

fix #364 - unused variables, detect enums used as template param or array dimension
This commit is contained in:
Brian Schott 2017-02-06 16:49:11 -08:00 committed by GitHub
parent 5f40f5ac9f 0afddd2c4e
commit 8a1dc98010
1 changed files with 36 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

36
src/analysis/unused.d
View File

@ -262,6 +262,26 @@ class UnusedVariableCheck : BaseAnalyzer
variableDeclaration.accept(this);
}
override void visit(const Type2 tp)
{
if (tp.symbol && tp.symbol.identifierOrTemplateChain &&
tp.symbol.identifierOrTemplateChain.identifiersOrTemplateInstances)
{
const IdentifierOrTemplateInstance idt = tp.symbol.identifierOrTemplateChain.identifiersOrTemplateInstances[0];
if (idt.identifier != tok!"")
variableUsed(idt.identifier.text);
else if (idt.templateInstance)
{
const TemplateInstance ti = idt.templateInstance;
if (ti.identifier != tok!"")
variableUsed(idt.templateInstance.identifier.text);
if (ti.templateArguments && ti.templateArguments.templateSingleArgument)
variableUsed(ti.templateArguments.templateSingleArgument.token.text);
}
}
tp.accept(this);
}
override void visit(const AutoDeclaration autoDeclaration)
{
foreach (t; autoDeclaration.parts.map!(a => a.identifier))
@ -453,6 +473,22 @@ unittest
return a;
}
// Issue 364
void test364_1()
{
enum s = 8;
immutable t = 2;
int[s][t] a;
a[0][0] = 1;
}
void test364_2()
{
enum s = 8;
alias a = e!s;
a = 1;
}
}c, sac);
stderr.writeln("Unittest for UnusedVariableCheck passed.");
}