forks
/
D-Scanner
mirror of https://github.com/dlang-community/D-Scanner.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #381 from BBasile/issue-380 

fix #380, templated enum seen as unused variable
This commit is contained in:
Brian Schott 2017-01-03 14:58:24 -08:00 committed by GitHub
parent c4fd1e1765 15b86bf159
commit 7c9257ebe3
1 changed files with 22 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
src/analysis/unused.d
View File

@ -10,7 +10,7 @@ import analysis.base;
import std.container;
import std.regex : Regex, regex, matchAll;
import dsymbol.scope_ : Scope;
import std.algorithm : map;
import std.algorithm.iteration : map;
/**
* Checks for unused variables.
@ -207,10 +207,14 @@ class UnusedVariableCheck : BaseAnalyzer
{
if (interestDepth > 0)
{
if (primary.identifierOrTemplateInstance !is null
&& primary.identifierOrTemplateInstance.identifier != tok!"")
const IdentifierOrTemplateInstance idt = primary.identifierOrTemplateInstance;
if (idt !is null)
{
variableUsed(primary.identifierOrTemplateInstance.identifier.text);
if (idt.identifier != tok!"")
variableUsed(idt.identifier.text);
else if (idt.templateInstance && idt.templateInstance.identifier != tok!"")
variableUsed(idt.templateInstance.identifier.text);
}
if (mixinDepth > 0 && primary.primary == tok!"stringLiteral"
|| primary.primary == tok!"wstringLiteral"
@ -430,6 +434,20 @@ unittest
int a; // [warn]: Variable a is never used.
}
// Issue 380
int templatedEnum()
{
enum a(T) = T.init;
return a!int;
}
// Issue 380
int otherTemplatedEnum()
{
auto a(T) = T.init; // [warn]: Variable a is never used.
return 0;
}
void doStuff(int a, int b) // [warn]: Parameter b is never used.
{
return a;