From 6fad779ec2d0984ccb17161aa1e78e9f0e1965b6 Mon Sep 17 00:00:00 2001 From: Sebastian Wilzbach Date: Mon, 12 Jun 2017 10:29:00 +0200 Subject: [PATCH] Fix #439 - Line length false positives in Phobos (#440) --- src/analysis/line_length.d | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/analysis/line_length.d b/src/analysis/line_length.d index 8c1a979..61fcb3d 100644 --- a/src/analysis/line_length.d +++ b/src/analysis/line_length.d @@ -32,7 +32,7 @@ class LineLengthCheck : BaseAnalyzer { immutable info = tokenLength(token, i > 0 ? tokens[i - 1].line : 0); if (info[1]) - endColumn = info[0] + token.column; + endColumn = info[0] + token.column - 1; else { immutable wsChange = i > 0 @@ -93,6 +93,10 @@ private: sac.long_line_check = Check.enabled; assertAnalyzerWarnings(q{ Window window = Platform.instance.createWindow("Дистанционное управление сварочным оборудованием", null); +unittest { + assert("foo" == "fooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooo"); + assert("foo" == "foooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooo"); // [warn]: Line is longer than 120 characters +} }c, sac); stderr.writeln("Unittest for LineLengthCheck passed.");