From 6d34b149a91607dc4b8ff4916ea71f0167d71ffd Mon Sep 17 00:00:00 2001 From: Sebastian Wilzbach Date: Mon, 12 Jun 2017 10:29:20 +0200 Subject: [PATCH] Fix #422 - False negative: sorted imports with : (#444) * Fix #422 - False negative: sorted imports with : * Fix #422: Add another test --- src/analysis/imports_sortedness.d | 17 ++++++++++++++++- 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/src/analysis/imports_sortedness.d b/src/analysis/imports_sortedness.d index d783040..ad6127c 100644 --- a/src/analysis/imports_sortedness.d +++ b/src/analysis/imports_sortedness.d @@ -72,7 +72,7 @@ class ImportSortednessCheck : BaseAnalyzer foreach (importBind; id.importBindings.importBinds) { - addImport(importModuleName ~ "_" ~ importBind.left.text, id.importBindings.singleImport); + addImport(importModuleName ~ "-" ~ importBind.left.text, id.importBindings.singleImport); } } } @@ -341,5 +341,20 @@ unittest ImportSortednessCheck.MESSAGE, ), sac); + // issue 422 - sorted imports with : + assertAnalyzerWarnings(q{ + import foo.bar : bar; + import foo.barbar; + }, sac); + + // issue 422 - sorted imports with : + assertAnalyzerWarnings(q{ + import foo; + import foo.bar; + import fooa; + import std.range : Take; + import std.range.primitives : isInputRange, walkLength; + }, sac); + stderr.writeln("Unittest for ImportSortednessCheck passed."); }