Death to the comma operator

makefile

@@ -48,5 +48,5 @@ clean:
 	rm -f dscanner-report.json
 
 report: all
-	dscanner --report src > dscanner-report.json
+	dscanner --report src > src/dscanner-report.json
 	sonar-runner

src/analysis/comma_expression.d

@@ -0,0 +1,37 @@
+//          Copyright Brian Schott (Hackerpilot) 2014.
+// Distributed under the Boost Software License, Version 1.0.
+//    (See accompanying file LICENSE_1_0.txt or copy at
+//          http://www.boost.org/LICENSE_1_0.txt)
+
+module analysis.comma_expression;
+
+import std.d.ast;
+import std.d.lexer;
+import analysis.base;
+
+import std.stdio;
+
+/**
+ * Check for uses of the comma expression.
+ */
+class CommaExpressionCheck : BaseAnalyzer
+{
+	alias visit = BaseAnalyzer.visit;
+
+	this(string fileName)
+	{
+		super(fileName);
+	}
+
+	override void visit(const Expression ex)
+	{
+		if (ex.items.length > 1)
+		{
+			addErrorMessage(ex.items[1].line, ex.items[1].column, KEY,
+				"Avoid using the comma expression.");
+		}
+		ex.accept(this);
+	}
+
+	private enum KEY = "dscanner.suspicious.comma_expression";
+}

src/analysis/config.d

@@ -74,4 +74,7 @@ struct StaticAnalysisConfig
 
 	@INI("Checks for poor placement of function attributes")
 	bool function_attribute_check;
+
+	@INI("Checks for use of the comma operator")
+	bool comma_expression_check;
 }

src/analysis/run.d

@@ -36,6 +36,7 @@ import analysis.asm_style;
 import analysis.logic_precedence;
 import analysis.stats_collector;
 import analysis.undocumented;
+import analysis.comma_expression;
 import analysis.function_attributes;
 
 bool first = true;
@@ -183,6 +184,7 @@ MessageSet analyze(string fileName, const Module m,
 	if (analysisConfig.logical_precedence_check) checks ~= new LogicPrecedenceCheck(fileName);
 	if (analysisConfig.undocumented_declaration_check) checks ~= new UndocumentedDeclarationCheck(fileName);
 	if (analysisConfig.function_attribute_check) checks ~= new FunctionAttributeCheck(fileName);
+	if (analysisConfig.comma_expression_check) checks ~= new CommaExpressionCheck(fileName);
 
 	foreach (check; checks)
 	{