forks
/
D-Scanner
mirror of https://github.com/dlang-community/D-Scanner.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Do not flag abstract functions in classes inside of interfaces

This commit is contained in:
Hackerpilot 2014-11-24 15:35:56 -08:00
parent 0b28dfa652
commit 6569468502
1 changed files with 13 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
src/analysis/function_attributes.d
View File

@ -32,9 +32,18 @@ class FunctionAttributeCheck : BaseAnalyzer
override void visit(const InterfaceDeclaration dec) override void visit(const InterfaceDeclaration dec)
{ {
inInterface++; auto t = inInterface;
inInterface = true;
dec.accept(this); dec.accept(this);
inInterface--; inInterface = t;
}
override void visit(const ClassDeclaration dec)
{
auto t = inInterface;
inInterface = false;
dec.accept(this);
inInterface = t;
} }
override void visit(const AttributeDeclaration dec) override void visit(const AttributeDeclaration dec)
@ -55,7 +64,7 @@ class FunctionAttributeCheck : BaseAnalyzer
{ {
if (attr.storageClass is null) if (attr.storageClass is null)
continue; continue;
if (attr.storageClass.token == tok!"abstract" && inInterface > 0) if (attr.storageClass.token == tok!"abstract" && inInterface)
{ {
addErrorMessage(attr.storageClass.token.line, addErrorMessage(attr.storageClass.token.line,
attr.storageClass.token.column, KEY, ABSTRACT_MESSAGE); attr.storageClass.token.column, KEY, ABSTRACT_MESSAGE);
@ -78,7 +87,7 @@ class FunctionAttributeCheck : BaseAnalyzer
dec.accept(this); dec.accept(this);
} }
int inInterface; bool inInterface;
private enum ABSTRACT_MESSAGE = "'abstract' attribute is redundant in interface declarations"; private enum ABSTRACT_MESSAGE = "'abstract' attribute is redundant in interface declarations";
private enum KEY = "dscanner.confusing.function_attributes"; private enum KEY = "dscanner.confusing.function_attributes";