From 1bc03367b4559fa76b8b84529cceccccad936166 Mon Sep 17 00:00:00 2001 From: Hackerpilot <briancschott@gmail.com> Date: Mon, 22 Jun 2020 19:01:05 -0700 Subject: [PATCH 1/2] Disable the local imports check by default --- src/dscanner/analysis/config.d | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/dscanner/analysis/config.d b/src/dscanner/analysis/config.d index b0e5be3..8ea0b20 100644 --- a/src/dscanner/analysis/config.d +++ b/src/dscanner/analysis/config.d @@ -123,7 +123,7 @@ struct StaticAnalysisConfig string comma_expression_check = Check.enabled; @INI("Checks for local imports that are too broad") - string local_import_check = Check.enabled; + string local_import_check = Check.disabled; @INI("Checks for variables that could be declared immutable") string could_be_immutable_check = Check.enabled; From 4bca597f4bf34d9a1ef7e4841f5ebd054e1346a4 Mon Sep 17 00:00:00 2001 From: Hackerpilot <briancschott@gmail.com> Date: Mon, 22 Jun 2020 22:18:12 -0700 Subject: [PATCH 2/2] Update the documentation for the local import rule --- src/dscanner/analysis/config.d | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/dscanner/analysis/config.d b/src/dscanner/analysis/config.d index 8ea0b20..f2f377c 100644 --- a/src/dscanner/analysis/config.d +++ b/src/dscanner/analysis/config.d @@ -122,7 +122,7 @@ struct StaticAnalysisConfig @INI("Checks for use of the comma operator") string comma_expression_check = Check.enabled; - @INI("Checks for local imports that are too broad") + @INI("Checks for local imports that are too broad. Only accurate when checking code used with D versions older than 2.071.0") string local_import_check = Check.disabled; @INI("Checks for variables that could be declared immutable")