forks
/
D-Scanner
mirror of https://github.com/dlang-community/D-Scanner.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #660 from BBasile/issue-659 

fix #659 - has opEquals but not toHash warning even if opEquals is di…
merged-on-behalf-of: Brian Schott <Hackerpilot@users.noreply.github.com>
This commit is contained in:
The Dlang Bot 2018-06-12 21:53:59 +02:00 committed by GitHub
parent 40a0a9d9be b5597e6bb6
commit 5a6101084f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 20 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
src/dscanner/analysis/opequals_without_tohash.d
View File

@ -54,6 +54,19 @@ final class OpEqualsWithoutToHashCheck : BaseAnalyzer
if (!declaration || !declaration.functionDeclaration)
continue;
bool containsDisable(A)(const A[] attribs)
{
import std.algorithm.searching : canFind;
return attribs.canFind!(a => a.atAttribute !is null &&
a.atAttribute.identifier.text == "disable");
}
const isDeclationDisabled = containsDisable(declaration.attributes) ||
containsDisable(declaration.functionDeclaration.memberFunctionAttributes);
if (isDeclationDisabled)
continue;
// Check if opEquals or toHash
immutable string methodName = declaration.functionDeclaration.name.text;
if (methodName == "opEquals")
@ -146,6 +159,13 @@ unittest
return 0;
}
}
// issue #659, do not warn if one miss and the other is not callable
struct Fox {const nothrow @safe hash_t toHash() @disable;}
struct Bat {@disable const nothrow @safe hash_t toHash();}
struct Rat {const bool opEquals(Object a, Object b) @disable;}
struct Cat {@disable const bool opEquals(Object a, Object b);}
}c, sac);
stderr.writeln("Unittest for OpEqualsWithoutToHashCheck passed.");