forks
/
D-Scanner
mirror of https://github.com/dlang-community/D-Scanner.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #646 from BBasile/issue-645 

fix #645 - False positive, Else branch identical to Then branch with incomplete IfStatement
merged-on-behalf-of: BBasile <BBasile@users.noreply.github.com>
This commit is contained in:
The Dlang Bot 2018-06-02 06:16:35 +02:00 committed by GitHub
parent 410d43028a f78d3e72b9
commit 4b394c2a7d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/dscanner/analysis/ifelsesame.d
View File

@ -31,7 +31,7 @@ final class IfElseSameCheck : BaseAnalyzer
override void visit(const IfStatement ifStatement) override void visit(const IfStatement ifStatement)
{ {
if (ifStatement.thenStatement == ifStatement.elseStatement) if (ifStatement.thenStatement && (ifStatement.thenStatement == ifStatement.elseStatement))
addErrorMessage(ifStatement.line, ifStatement.column, addErrorMessage(ifStatement.line, ifStatement.column,
"dscanner.bugs.if_else_same", "'Else' branch is identical to 'Then' branch."); "dscanner.bugs.if_else_same", "'Else' branch is identical to 'Then' branch.");
ifStatement.accept(this); ifStatement.accept(this);
@ -95,5 +95,13 @@ unittest
person = "bobby"; // not same person = "bobby"; // not same
} }
}c, sac); }c, sac);
assertAnalyzerWarnings(q{
void foo()
{
if (auto stuff = call())
}
}c, sac);
stderr.writeln("Unittest for IfElseSameCheck passed."); stderr.writeln("Unittest for IfElseSameCheck passed.");
} }