forks
/
D-Scanner
mirror of https://github.com/dlang-community/D-Scanner.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix #256

This commit is contained in:
Hackerpilot 2015-05-17 17:12:37 -07:00
parent 960881e607
commit 4786c1fc1b
2 changed files with 19 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
makefile
View File

@ -11,6 +11,8 @@ SRC = src/*.d\
INCLUDE_PATHS = -Ilibdparse/src INCLUDE_PATHS = -Ilibdparse/src
VERSIONS = VERSIONS =
DEBUG_VERSIONS = -version=std_parser_verbose DEBUG_VERSIONS = -version=std_parser_verbose
DMD_FLAGS = -w -O -release -inline
#DMD_FLAGS = -w
all: dmdbuild all: dmdbuild
ldc: ldcbuild ldc: ldcbuild
@ -24,7 +26,7 @@ debug:
dmdbuild: githash dmdbuild: githash
mkdir -p bin mkdir -p bin
${DMD} -w -O -release -inline -ofbin/dscanner ${VERSIONS} ${INCLUDE_PATHS} ${SRC} -J. ${DMD} -ofbin/dscanner ${VERSIONS} ${INCLUDE_PATHS} ${SRC} -J.
rm -f bin/dscanner.o rm -f bin/dscanner.o
gdcbuild: githash gdcbuild: githash

19
src/analysis/redundant_parens.d
View File

@ -29,17 +29,30 @@ class RedundantParenCheck : BaseAnalyzer
unary = cast(UnaryExpression) statement.expression.items[0]; unary = cast(UnaryExpression) statement.expression.items[0];
if (unary is null) if (unary is null)
goto end; goto end;
visit(unary.primaryExpression); if (unary.primaryExpression is null)
goto end;
if (unary.primaryExpression.expression is null)
goto end;
addErrorMessage(unary.primaryExpression.expression.line,
unary.primaryExpression.expression.column, KEY, "Redundant parenthesis");
end: end:
statement.accept(this); statement.accept(this);
} }
override void visit(const PrimaryExpression primaryExpression) override void visit(const PrimaryExpression primaryExpression)
{ {
if (primaryExpression is null) import std.stdio : stderr;
goto end;
UnaryExpression unary;
if (primaryExpression.expression is null) if (primaryExpression.expression is null)
goto end; goto end;
unary = cast(UnaryExpression) primaryExpression.expression.items[0];
if (unary is null)
goto end;
if (unary.primaryExpression is null)
goto end;
if (unary.primaryExpression.expression is null)
goto end;
addErrorMessage(primaryExpression.expression.line, addErrorMessage(primaryExpression.expression.line,
primaryExpression.expression.column, KEY, "Redundant parenthesis"); primaryExpression.expression.column, KEY, "Redundant parenthesis");
end: end: