forks
/
D-Scanner
mirror of https://github.com/dlang-community/D-Scanner.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #466 from wilzbach/fix-unused_label 

Fix AssertError on unknown label in unused_label
merged-on-behalf-of: Sebastian Wilzbach <sebi.wilzbach@gmail.com>
This commit is contained in:
The Dlang Bot 2017-06-27 22:24:26 +02:00 committed by GitHub
parent 61d52156aa 36397a579d
commit 38c4d2d0eb
1 changed files with 24 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
src/analysis/unused_label.d
View File

@ -143,8 +143,11 @@ private:
{ {
foreach (label; current.byValue()) foreach (label; current.byValue())
{ {
assert(label.line != size_t.max && label.column != size_t.max); if (label.line == size_t.max || label.column == size_t.max)
if (!label.used) {
// TODO: handle unknown labels
}
else if (!label.used)
{ {
addErrorMessage(label.line, label.column, "dscanner.suspicious.unused_label", addErrorMessage(label.line, label.column, "dscanner.suspicious.unused_label",
"Label \"" ~ label.name ~ "\" is not used."); "Label \"" ~ label.name ~ "\" is not used.");
@ -225,5 +228,24 @@ unittest
} }
}c, sac); }c, sac);
// from std.math
assertAnalyzerWarnings(q{
real polyImpl() {
asm {
jecxz return_ST;
}
}
}c, sac);
// a label might be hard to find, e.g. in a mixin
assertAnalyzerWarnings(q{
real polyImpl() {
mixin("return_ST: return 1;");
asm {
jecxz return_ST;
}
}
}c, sac);
stderr.writeln("Unittest for UnusedLabelCheck passed."); stderr.writeln("Unittest for UnusedLabelCheck passed.");
} }