forks
/
D-Scanner
mirror of https://github.com/dlang-community/D-Scanner.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix #762 - False positive on "unused variable" with side effect (#763)

This commit is contained in:
Basile-z 2019-05-29 11:11:03 +02:00 committed by GitHub
parent e5a73fa0ef
commit 378cbcc6bd
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 10 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
src/dscanner/analysis/unused.d
View File

@ -166,14 +166,9 @@ final class UnusedVariableCheck : BaseAnalyzer
override void visit(const AssignExpression assignExp) override void visit(const AssignExpression assignExp)
{ {
if (assignExp.ternaryExpression !is null) interestDepth++;
assignExp.ternaryExpression.accept(this); assignExp.accept(this);
if (assignExp.expression !is null) interestDepth--;
{
interestDepth++;
assignExp.expression.accept(this);
interestDepth--;
}
} }
override void visit(const TemplateDeclaration templateDeclaration) override void visit(const TemplateDeclaration templateDeclaration)
@ -542,6 +537,13 @@ private:
auto cb2 = delegate(size_t a) {}; // [warn]: Parameter a is never used. auto cb2 = delegate(size_t a) {}; // [warn]: Parameter a is never used.
cb2(3); cb2(3);
} }
void oops ()
{
class Identity { int val; }
Identity v;
v.val = 0;
}
bool hasDittos(int decl) bool hasDittos(int decl)
{ {