forks
/
D-Scanner
mirror of https://github.com/dlang-community/D-Scanner.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #657 from BBasile/issue-656 

fix #656 - Crash due to unsafe access in infinite range check
merged-on-behalf-of: BBasile <BBasile@users.noreply.github.com>
This commit is contained in:
The Dlang Bot 2018-06-08 13:41:47 +02:00 committed by GitHub
parent 539f5b127e c51dcd98a7
commit 32dd411ab5
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 11 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/dscanner/analysis/incorrect_infinite_range.d
View File

@ -62,7 +62,7 @@ final class IncorrectInfiniteRangeCheck : BaseAnalyzer
override void visit(const ReturnStatement rs) override void visit(const ReturnStatement rs)
{ {
if (rs.expression.items.length != 1) if (!rs.expression || rs.expression.items.length != 1)
return; return;
UnaryExpression unary = cast(UnaryExpression) rs.expression.items[0]; UnaryExpression unary = cast(UnaryExpression) rs.expression.items[0];
if (unary is null) if (unary is null)
@ -126,3 +126,13 @@ class C { bool empty() { return false; } } // [warn]: %1$s
stderr.writeln("Unittest for IncorrectInfiniteRangeCheck passed."); stderr.writeln("Unittest for IncorrectInfiniteRangeCheck passed.");
} }
// test for https://github.com/dlang-community/D-Scanner/issues/656
// unittests are skipped but D-Scanner sources are self checked
version(none) struct Foo
{
void empty()
{
return;
}
}