forks
/
D-Scanner
mirror of https://github.com/dlang-community/D-Scanner.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

More correct checking for undocumented declarations

This commit is contained in:
Hackerpilot 2016-01-25 15:14:46 -08:00
parent 900bb9f996
commit 314b0ef3df
2 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/analysis/undocumented.d
View File

@ -93,7 +93,7 @@ class UndocumentedDeclarationCheck : BaseAnalyzer
override void visit(const VariableDeclaration variable)
{
if (!currentIsInteresting() || variable.comment !is null)
if (!currentIsInteresting() || variable.comment.ptr !is null)
return;
if (variable.autoDeclaration !is null)
{
@ -104,7 +104,8 @@ class UndocumentedDeclarationCheck : BaseAnalyzer
}
foreach (dec; variable.declarators)
{
addMessage(dec.name.line, dec.name.column, dec.name.text);
if (dec.comment.ptr is null)
addMessage(dec.name.line, dec.name.column, dec.name.text);
return;
}
}
@ -140,7 +141,7 @@ private:
import std.traits : hasMember;
if (currentIsInteresting())
{
if (declaration.comment is null)
if (declaration.comment.ptr is null)
{
static if (hasMember!(T, "name"))
{

2
src/astprinter.d
View File

@ -1116,7 +1116,7 @@ class XMLPrinter : ASTVisitor
private void writeDdoc(string comment)
{
if (comment is null) return;
if (comment.ptr is null) return;
output.writeln("<ddoc>", xmlEscape(comment), "</ddoc>");
}