forks
/
D-Scanner
mirror of https://github.com/dlang-community/D-Scanner.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #428 from BBasile/issue-352 

fix #352 - False positive: Parameter is never used, pointers
This commit is contained in:
Basile Burg 2017-05-17 14:50:02 +02:00 committed by GitHub
parent e844a98f4d cd5dbd84e0
commit 28945dec81
1 changed files with 25 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

32
src/analysis/unused.d
View File

@ -299,17 +299,21 @@ class UnusedVariableCheck : BaseAnalyzer
override void visit(const Parameter parameter) override void visit(const Parameter parameter)
{ {
import std.algorithm : canFind; import std.algorithm : among;
import std.algorithm.iteration : filter;
import std.range : empty;
import std.array : array; import std.array : array;
if (parameter.name != tok!"") if (parameter.name != tok!"")
{ {
immutable bool isRef = canFind(parameter.parameterAttributes, cast(IdType) tok!"ref") immutable bool isRef = !parameter.parameterAttributes
|| canFind(parameter.parameterAttributes, .filter!(a => a.among(tok!"ref", tok!"out")).empty;
cast(IdType) tok!"in") || canFind(parameter.parameterAttributes, immutable bool isPtr = parameter.type && !parameter.type
cast(IdType) tok!"out"); .typeSuffixes.filter!(a => a.star != tok!"").empty;
variableDeclared(parameter.name.text, parameter.name.line, variableDeclared(parameter.name.text, parameter.name.line,
parameter.name.column, true, isRef); parameter.name.column, true, isRef | isPtr);
if (parameter.default_ !is null) if (parameter.default_ !is null)
{ {
interestDepth++; interestDepth++;
@ -432,7 +436,7 @@ private:
Regex!char re; Regex!char re;
} }
unittest @system unittest
{ {
import std.stdio : stderr; import std.stdio : stderr;
import analysis.config : StaticAnalysisConfig, Check, disabledConfig; import analysis.config : StaticAnalysisConfig, Check, disabledConfig;
@ -454,6 +458,8 @@ unittest
int a; // [warn]: Variable a is never used. int a; // [warn]: Variable a is never used.
} }
void inPSC(in int a){} // [warn]: Parameter a is never used.
// Issue 380 // Issue 380
int templatedEnum() int templatedEnum()
{ {
@ -489,6 +495,18 @@ unittest
a = 1; a = 1;
} }
// Issue 352
void test352_1()
{
void f(int *x) {*x = 1;}
}
void test352_2()
{
void f(Bat** bat) {*bat = bats.ptr + 8;}
}
}c, sac); }c, sac);
stderr.writeln("Unittest for UnusedVariableCheck passed."); stderr.writeln("Unittest for UnusedVariableCheck passed.");
} }