forks
/
D-Scanner
mirror of https://github.com/dlang-community/D-Scanner.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Address @BBasile's review

This commit is contained in:
Sebastian Wilzbach 2016-12-16 00:52:17 +01:00
parent 7f38c87f5d
commit 1c89a01f33
1 changed files with 11 additions and 34 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

45
src/analysis/explicitly_annotated_unittests.d
View File

@ -28,13 +28,13 @@ class ExplicitlyAnnotatedUnittestCheck : BaseAnalyzer
{
if (decl.unittest_ !is null)
{
bool isSafeOrSystem = false;
bool isSafeOrSystem;
if (decl.attributes !is null)
foreach (attribute; decl.attributes)
{
if (attribute.atAttribute !is null)
{
auto token = attribute.atAttribute.identifier.text;
const token = attribute.atAttribute.identifier.text;
if (token == "safe" || token == "system")
{
isSafeOrSystem = true;
@ -63,25 +63,12 @@ unittest
sac.explicitly_annotated_unittests = Check.enabled;
assertAnalyzerWarnings(q{
@safe unittest {
@safe unittest {}
@system unittest {}
pure nothrow @system @nogc unittest {}
}
@system unittest {
}
pure nothrow @system @nogc unittest {
}
unittest // [warn]: %s
{
}
pure nothrow @nogc unittest // [warn]: %s
{
}
unittest {} // [warn]: %s
pure nothrow @nogc unittest {} // [warn]: %s
}c.format(
ExplicitlyAnnotatedUnittestCheck.MESSAGE,
ExplicitlyAnnotatedUnittestCheck.MESSAGE,
@ -91,21 +78,11 @@ unittest
assertAnalyzerWarnings(q{
struct Foo
{
@safe unittest {
@safe unittest {}
@system unittest {}
}
@system unittest {
}
unittest // [warn]: %s
{
}
pure nothrow @nogc unittest // [warn]: %s
{
}
unittest {} // [warn]: %s
pure nothrow @nogc unittest {} // [warn]: %s
}
}c.format(
ExplicitlyAnnotatedUnittestCheck.MESSAGE,