forks
/
D-Scanner
mirror of https://github.com/dlang-community/D-Scanner.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix #791

This commit is contained in:
brianush1 2022-12-28 12:16:53 -05:00 committed by Jan Jurzitza
parent 9b171c46d2
commit 14ba4af4bd
1 changed files with 30 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
src/dscanner/analysis/function_attributes.d
View File

@ -35,17 +35,45 @@ final class FunctionAttributeCheck : BaseAnalyzer
override void visit(const InterfaceDeclaration dec) override void visit(const InterfaceDeclaration dec)
{ {
const t = inInterface; const t = inInterface;
const t2 = inAggregate;
inInterface = true; inInterface = true;
inAggregate = true;
dec.accept(this); dec.accept(this);
inInterface = t; inInterface = t;
inAggregate = t2;
} }
override void visit(const ClassDeclaration dec) override void visit(const ClassDeclaration dec)
{ {
const t = inInterface; const t = inInterface;
const t2 = inAggregate;
inInterface = false; inInterface = false;
inAggregate = true;
dec.accept(this); dec.accept(this);
inInterface = t; inInterface = t;
inAggregate = t2;
}
override void visit(const StructDeclaration dec)
{
const t = inInterface;
const t2 = inAggregate;
inInterface = false;
inAggregate = true;
dec.accept(this);
inInterface = t;
inAggregate = t2;
}
override void visit(const UnionDeclaration dec)
{
const t = inInterface;
const t2 = inAggregate;
inInterface = false;
inAggregate = true;
dec.accept(this);
inInterface = t;
inAggregate = t2;
} }
override void visit(const AttributeDeclaration dec) override void visit(const AttributeDeclaration dec)
@ -59,7 +87,7 @@ final class FunctionAttributeCheck : BaseAnalyzer
override void visit(const FunctionDeclaration dec) override void visit(const FunctionDeclaration dec)
{ {
if (dec.parameters.parameters.length == 0) if (dec.parameters.parameters.length == 0 && inAggregate)
{ {
bool foundConst; bool foundConst;
bool foundProperty; bool foundProperty;
@ -115,6 +143,7 @@ final class FunctionAttributeCheck : BaseAnalyzer
private: private:
bool inInterface; bool inInterface;
bool inAggregate;
enum string ABSTRACT_MESSAGE = "'abstract' attribute is redundant in interface declarations"; enum string ABSTRACT_MESSAGE = "'abstract' attribute is redundant in interface declarations";
enum string KEY = "dscanner.confusing.function_attributes"; enum string KEY = "dscanner.confusing.function_attributes";
} }