forks
/
D-Scanner
mirror of https://github.com/dlang-community/D-Scanner.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Warn about redundant 'abstract' attribute on functions in interfaces. Fixes #202

This commit is contained in:
Hackerpilot 2014-11-24 15:13:19 -08:00
parent 504fcc830e
commit 03454d6b65
2 changed files with 18 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
README.md
View File

@ -78,6 +78,7 @@ you do not want to use the one created by the "--defaultConfig" option.
* Class, struct, and union member variables whose names conflict with built-in type properties. * Class, struct, and union member variables whose names conflict with built-in type properties.
* Confusing asm syntax. * Confusing asm syntax.
* Placement of const, immutable, or inout before a function return type instead of after the parameters. * Placement of const, immutable, or inout before a function return type instead of after the parameters.
* Functions in interface declarations redundantly marked 'abstract'.
#### Wishlish #### Wishlish
* Assigning to foreach variables that are not "ref". * Assigning to foreach variables that are not "ref".

17
src/analysis/function_attributes.d
View File

@ -30,6 +30,13 @@ class FunctionAttributeCheck : BaseAnalyzer
super(fileName); super(fileName);
} }
override void visit(const InterfaceDeclaration dec)
{
inInterface++;
dec.accept(this);
inInterface--;
}
override void visit(const Declaration dec) override void visit(const Declaration dec)
{ {
if (dec.functionDeclaration is null) if (dec.functionDeclaration is null)
@ -40,6 +47,14 @@ class FunctionAttributeCheck : BaseAnalyzer
{ {
if (attr.storageClass is null) if (attr.storageClass is null)
continue; continue;
if (attr.storageClass.token == tok!"abstract" && inInterface > 0)
{
addErrorMessage(dec.functionDeclaration.name.line,
dec.functionDeclaration.name.column, KEY,
"'abstract' attribute on interface function has"
~ " no effect.");
continue;
}
if (attr.storageClass.token == tok!"const" if (attr.storageClass.token == tok!"const"
|| attr.storageClass.token == tok!"inout" || attr.storageClass.token == tok!"inout"
|| attr.storageClass.token == tok!"immutable") || attr.storageClass.token == tok!"immutable")
@ -56,5 +71,7 @@ class FunctionAttributeCheck : BaseAnalyzer
dec.accept(this); dec.accept(this);
} }
int inInterface;
private enum KEY = "dscanner.confusing.function_attributes"; private enum KEY = "dscanner.confusing.function_attributes";
} }